xbkaishui commented on a change in pull request #6352:
URL: https://github.com/apache/shardingsphere/pull/6352#discussion_r456744464
##########
File path:
shardingsphere-proxy/shardingsphere-proxy-backend/src/main/java/org/apache/shardingsphere/proxy/backend/communication/jdbc/recognizer/impl/H2Recognizer.java
##########
@@ -27,9 +28,11 @@
*/
public final class H2Recognizer implements JDBCDriverURLRecognizer {
+ private final H2DatabaseType databaseType = new H2DatabaseType();
+
@Override
public String getDatabaseType() {
Review comment:
I saw the code contains so many literals of databaseType, is it better
to refers only *DatabaseType class ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
