tristaZero commented on a change in pull request #6370:
URL: https://github.com/apache/shardingsphere/pull/6370#discussion_r458654623
##########
File path:
shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-postgresql/src/main/java/org/apache/shardingsphere/sql/parser/postgresql/visitor/PostgreSQLVisitor.java
##########
@@ -262,14 +262,15 @@ private PredicateSegment createInSegment(final
AExprContext ctx) {
private Collection<ExpressionSegment> getExpressionSegments(final
AExprContext ctx) {
Collection<ExpressionSegment> result = new LinkedList<>();
-// if (null != ctx.cExpr() && null != ctx.cExpr().select_with_parens())
{
-// Select_with_parensContext subquery =
ctx.cExpr().select_with_parens();
+// TODO deal with sqlExpressions in PredicateInRightValue
+// if (null != ctx.cExpr() && null != ctx.cExpr().selectWithParens()) {
+// PostgreSQLStatementParser.SelectWithParensContext subquery =
ctx.cExpr().selectWithParens();
// result.add(new SubqueryExpressionSegment(new
SubquerySegment(subquery.getStart().getStartIndex(),
subquery.getStop().getStopIndex(),
-// (SelectStatement)
visit(ctx.cExpr().select_with_parens()))));
Review comment:
Do you think these codes can be removed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
