tristaZero commented on a change in pull request #6542:
URL: https://github.com/apache/shardingsphere/pull/6542#discussion_r463372420
##########
File path:
shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/util/SQLUtil.java
##########
@@ -95,6 +95,9 @@ public static String
getExpressionWithoutOutsideParentheses(final String value)
private static int getParenthesesOffset(final String value) {
int result = 0;
+ if(Strings.isNullOrEmpty(value)){
+ return result;
+ }
Review comment:
A unit test is expected to add in
`org.apache.shardingsphere.sql.parser.sql.util.SQLUtilTest`.
##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-statement/pom.xml
##########
@@ -34,5 +34,9 @@
<artifactId>shardingsphere-sql-parser-spi</artifactId>
<version>${project.version}</version>
</dependency>
+ <dependency>
+ <groupId>com.google.guava</groupId>
Review comment:
Is it necessary?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
