SirMin commented on pull request #6359:
URL: https://github.com/apache/shardingsphere/pull/6359#issuecomment-667939364


   Hi @tristaZero 
   >1. Maybe newInstance() is better to rename getInstance()
   >2. As you said, we'd better add more java doc concerning `thread and its 
usage.
   
   I agree more with the second. Because I think this API is user-oriented, 
it's best to keep it stable.
   
   > Would you mind giving this class an improvement?
   
   add new pr?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to