Lucas-307 commented on a change in pull request #6883:
URL: https://github.com/apache/shardingsphere/pull/6883#discussion_r471204517
##########
File path:
shardingsphere-scaling/shardingsphere-scaling-core/src/main/java/org/apache/shardingsphere/scaling/core/config/DumperConfiguration.java
##########
@@ -17,51 +17,25 @@
package org.apache.shardingsphere.scaling.core.config;
-import lombok.EqualsAndHashCode;
import lombok.Getter;
import lombok.Setter;
-import lombok.SneakyThrows;
import org.apache.shardingsphere.scaling.core.job.position.PositionManager;
import java.util.Map;
-import java.util.Set;
/**
- * Relational database management system configuration.
+ * Dumper configuration.
*/
@Setter
@Getter
-@EqualsAndHashCode
-public final class RdbmsConfiguration implements Cloneable {
-
+public class DumperConfiguration implements Cloneable {
Review comment:
Please remove Cloneable interface. and impl clone() function in other
way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
