Lucas-307 commented on a change in pull request #6951:
URL: https://github.com/apache/shardingsphere/pull/6951#discussion_r473875929
##########
File path:
shardingsphere-infra/shardingsphere-infra-common/src/main/java/org/apache/shardingsphere/infra/database/type/dialect/H2DatabaseType.java
##########
@@ -49,4 +49,12 @@ public H2DataSourceMetaData getDataSourceMetaData(final
String url, final String
public DatabaseType getTrunkDatabaseType() {
return DatabaseTypes.getActualDatabaseType("MySQL");
}
+
+ @Override
+ public boolean equals(final Object obj) {
+ if (!(obj instanceof DatabaseType)) {
+ return false;
+ }
+ return getName().equals(((DatabaseType) obj).getName());
+ }
Review comment:
Please replace with @EqualsAndHashCode.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
