terrymanu commented on a change in pull request #6945:
URL: https://github.com/apache/shardingsphere/pull/6945#discussion_r474378451
##########
File path:
shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-spring/shardingsphere-sharding-spring-boot-starter/src/test/java/org/apache/shardingsphere/sharding/spring/boot/ShardingSpringBootStarterTest.java
##########
@@ -68,6 +74,47 @@ public void assertKeyGenerateAlgorithm() {
@Test
public void assertShardingConfiguration() {
assertThat(shardingRuleConfiguration.getTables().size(), is(2));
- // TODO assert sharding configuration
+ List<ShardingTableRuleConfiguration>
shardingTableRuleConfigurationList =
Lists.newArrayList(shardingRuleConfiguration.getTables());
+ assertThat(shardingTableRuleConfigurationList.get(0).getLogicTable(),
is("t_order"));
+
assertThat(shardingTableRuleConfigurationList.get(0).getActualDataNodes(),
is("ds_$->{0..1}.t_order_$->{0..1}"));
+
assertThat(shardingTableRuleConfigurationList.get(0).getTableShardingStrategy(),
instanceOf(StandardShardingStrategyConfiguration.class));
+ assertThat(((StandardShardingStrategyConfiguration)
shardingTableRuleConfigurationList.get(0).getTableShardingStrategy()).getShardingColumn(),
is("order_id"));
+
assertThat(shardingTableRuleConfigurationList.get(0).getTableShardingStrategy().getShardingAlgorithmName(),
is("orderTableShardingAlgorithm"));
+
assertThat(shardingTableRuleConfigurationList.get(0).getKeyGenerateStrategy().getColumn(),
is("order_id"));
+
assertThat(shardingTableRuleConfigurationList.get(0).getKeyGenerateStrategy().getKeyGeneratorName(),
is("keyGenerator"));
+ assertThat(shardingTableRuleConfigurationList.get(1).getLogicTable(),
is("t_order_item"));
+
assertThat(shardingTableRuleConfigurationList.get(1).getActualDataNodes(),
is("ds_$->{0..1}.t_order_item_$->{0..1}"));
+
assertThat(shardingTableRuleConfigurationList.get(1).getTableShardingStrategy(),
instanceOf(StandardShardingStrategyConfiguration.class));
+ assertThat(((StandardShardingStrategyConfiguration)
shardingTableRuleConfigurationList.get(1).getTableShardingStrategy()).getShardingColumn(),
is("order_id"));
+
assertThat(shardingTableRuleConfigurationList.get(1).getTableShardingStrategy().getShardingAlgorithmName(),
is("orderItemTableShardingAlgorithm"));
+
assertThat(shardingTableRuleConfigurationList.get(1).getKeyGenerateStrategy().getColumn(),
is("order_item_id"));
+
assertThat(shardingTableRuleConfigurationList.get(1).getKeyGenerateStrategy().getKeyGeneratorName(),
is("keyGenerator"));
+
+ assertThat(shardingRuleConfiguration.getBindingTableGroups().size(),
is(2));
+ List<String> bindingTableGroupsList = new
ArrayList<>(shardingRuleConfiguration.getBindingTableGroups());
+ assertThat(bindingTableGroupsList.get(0), is("t_order"));
+ assertThat(bindingTableGroupsList.get(1), is("t_order_item"));
+
+ assertThat(shardingRuleConfiguration.getBroadcastTables().size(),
is(1));
+
assertThat(shardingRuleConfiguration.getBroadcastTables().iterator().next(),
is("t_config"));
+
+
assertThat(shardingRuleConfiguration.getDefaultDatabaseShardingStrategy(),
instanceOf(StandardShardingStrategyConfiguration.class));
+ assertThat(((StandardShardingStrategyConfiguration)
shardingRuleConfiguration.getDefaultDatabaseShardingStrategy()).getShardingColumn(),
is("user_id"));
+
assertThat(shardingRuleConfiguration.getDefaultDatabaseShardingStrategy().getShardingAlgorithmName(),
is("databaseShardingAlgorithm"));
+
+ assertThat(shardingRuleConfiguration.getShardingAlgorithms().size(),
is(3));
+
assertThat(shardingRuleConfiguration.getShardingAlgorithms().get("orderItemTableShardingAlgorithm"),
instanceOf(InlineShardingAlgorithm.class));
+
assertThat(shardingRuleConfiguration.getShardingAlgorithms().get("orderItemTableShardingAlgorithm").getType(),
is("INLINE"));
+
assertThat(shardingRuleConfiguration.getShardingAlgorithms().get("orderItemTableShardingAlgorithm").getProps().getProperty("algorithm.expression"),
is("t_order_item_$->{order_id % 2}"));
+
assertThat(shardingRuleConfiguration.getShardingAlgorithms().get("databaseShardingAlgorithm"),
instanceOf(InlineShardingAlgorithm.class));
+
assertThat(shardingRuleConfiguration.getShardingAlgorithms().get("databaseShardingAlgorithm").getType(),
is("INLINE"));
+
assertThat(shardingRuleConfiguration.getShardingAlgorithms().get("databaseShardingAlgorithm").getProps().getProperty("algorithm.expression"),
is("ds_$->{user_id % 2}"));
+
assertThat(shardingRuleConfiguration.getShardingAlgorithms().get("orderTableShardingAlgorithm"),
instanceOf(InlineShardingAlgorithm.class));
+
assertThat(shardingRuleConfiguration.getShardingAlgorithms().get("orderTableShardingAlgorithm").getType(),
is("INLINE"));
+
assertThat(shardingRuleConfiguration.getShardingAlgorithms().get("orderTableShardingAlgorithm").getProps().getProperty("algorithm.expression"),
is("t_order_$->{order_id % 2}"));
+
Review comment:
For example:
assertShardingConfiguration can be composited by
assertTableShardingStrategy, assertDatabaseShardingStrategy, assertKeyGenerator
etc...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
