tuohai666 commented on a change in pull request #7076:
URL: https://github.com/apache/shardingsphere/pull/7076#discussion_r478811319
##########
File path:
shardingsphere-proxy/shardingsphere-proxy-frontend/shardingsphere-proxy-frontend-postgresql/src/main/java/org/apache/shardingsphere/proxy/frontend/postgresql/auth/PostgreSQLAuthenticationEngine.java
##########
@@ -91,7 +91,8 @@ public AuthenticationResult auth(final ChannelHandlerContext
context, final Pack
}
md5Salt =
PostgreSQLRandomGenerator.getInstance().generateRandomBytes(4);
context.writeAndFlush(new
PostgreSQLAuthenticationMD5PasswordPacket(md5Salt));
- return AuthenticationResult.continued(username, databaseName);
+ currentAuthResult = AuthenticationResult.continued(username,
databaseName);
Review comment:
Can remove currentAuthResult?
##########
File path:
shardingsphere-db-protocol/shardingsphere-db-protocol-postgresql/src/main/java/org/apache/shardingsphere/db/protocol/postgresql/packet/handshake/PostgreSQLAuthenticationMD5PasswordPacket.java
##########
@@ -29,6 +29,7 @@
private static final int AUTH_REQ_MD5 = 5;
+ @Getter
Review comment:
Where this member be called?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
