tristaZero commented on a change in pull request #7150:
URL: https://github.com/apache/shardingsphere/pull/7150#discussion_r479746324
##########
File path:
shardingsphere-sql-parser/shardingsphere-sql-parser-binder/src/main/java/org/apache/shardingsphere/sql/parser/binder/metadata/schema/SchemaMetaDataLoader.java
##########
@@ -105,7 +107,7 @@ public static SchemaMetaData load(final DataSource
dataSource, final int maxConn
private static List<String> loadAllTableNames(final Connection connection,
final String databaseType) throws SQLException {
List<String> result = new LinkedList<>();
- try (ResultSet resultSet =
connection.getMetaData().getTables(connection.getCatalog(),
JdbcUtil.getSchema(connection, databaseType), null, new String[]{TABLE_TYPE})) {
+ try (ResultSet resultSet =
connection.getMetaData().getTables(connection.getCatalog(),
JdbcUtil.getSchema(connection, databaseType), null, new String[]{TABLE_TYPE,
VIEW_TYPE})) {
Review comment:
Hi, why do we need to load `VIEW_TYPE `?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
