terrymanu commented on a change in pull request #7205:
URL: https://github.com/apache/shardingsphere/pull/7205#discussion_r481554105
##########
File path:
shardingsphere-integration-test/shardingsphere-test-suite/src/test/java/org/apache/shardingsphere/dbtest/env/authority/AuthorityEnvironmentManager.java
##########
@@ -83,10 +83,7 @@ private void executeOnInstanceDataSource(final DataSource
dataSource, final Coll
try (Connection connection = dataSource.getConnection()) {
for (String each : sqls) {
try (Statement statement = connection.createStatement()) {
- boolean executeRet = statement.execute(each);
- if (!executeRet) {
- System.err.println("execute '" + each + "' failed");
- }
+ statement.execute(each);
} catch (final SQLException ex) {
System.err.println("execute '" + each + "' failed,
ex.msg=" + ex.getMessage());
Review comment:
Please use `log.error` instead of `System.err.println`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
