flycoolman commented on a change in pull request #7416:
URL: https://github.com/apache/shardingsphere/pull/7416#discussion_r487364135
##########
File path: shardingsphere-features/pom.xml
##########
@@ -32,7 +32,7 @@
<modules>
<module>shardingsphere-sharding</module>
<module>shardingsphere-replica</module>
- <module>shardingsphere-master-slave</module>
+ <module>shardingsphere-primary-replica</module>
Review comment:
Got it!
If there are other places you can imagine to use other names, not just plain
translate from master-slave to primary-replica, please let me know.
##########
File path:
shardingsphere-features/shardingsphere-primary-replica/shardingsphere-primary-replica-api/src/main/java/org/apache/shardingsphere/primaryreplica/api/config/PrimaryReplicaRuleConfiguration.java
##########
@@ -15,25 +15,25 @@
* limitations under the License.
*/
-package org.apache.shardingsphere.masterslave.api.config;
+package org.apache.shardingsphere.primaryreplica.api.config;
import lombok.Getter;
import lombok.RequiredArgsConstructor;
import org.apache.shardingsphere.infra.config.RuleConfiguration;
import
org.apache.shardingsphere.infra.config.algorithm.ShardingSphereAlgorithmConfiguration;
-import
org.apache.shardingsphere.masterslave.api.config.rule.MasterSlaveDataSourceRuleConfiguration;
+import
org.apache.shardingsphere.primaryreplica.api.config.rule.PrimaryReplicaDataSourceRuleConfiguration;
import java.util.Collection;
import java.util.Map;
/**
- * Master-slave rule configuration.
+ * Primary-replica rule configuration.
*/
@RequiredArgsConstructor
@Getter
-public final class MasterSlaveRuleConfiguration implements RuleConfiguration {
+public final class PrimaryReplicaRuleConfiguration implements
RuleConfiguration {
Review comment:
Will change
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
