tristaZero commented on a change in pull request #7371:
URL: https://github.com/apache/shardingsphere/pull/7371#discussion_r486743084



##########
File path: 
shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/common/statement/dml/InsertStatement.java
##########
@@ -43,7 +43,7 @@
  */
 @Getter
 @Setter
-public final class InsertStatement extends AbstractSQLStatement implements 
DMLStatement {
+public abstract class InsertStatement extends AbstractSQLStatement {

Review comment:
       Thanks for your explanation. @jingshanglu Could you give it a look to 
check whether there will be any conflicts?

##########
File path: 
shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/common/statement/dml/InsertStatement.java
##########
@@ -43,7 +43,7 @@
  */
 @Getter
 @Setter
-public final class InsertStatement extends AbstractSQLStatement implements 
DMLStatement {
+public abstract class InsertStatement extends AbstractSQLStatement {

Review comment:
       Thanks for your explanation. @jingshanglu Could you give it a look to 
check whether there will be any conflicts?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to