strongduanmu commented on a change in pull request #7469:
URL: https://github.com/apache/shardingsphere/pull/7469#discussion_r489159903
##########
File path:
shardingsphere-sql-parser/shardingsphere-sql-parser-test/src/main/java/org/apache/shardingsphere/test/sql/parser/parameterized/asserts/statement/dml/impl/DeleteStatementAssert.java
##########
@@ -49,8 +51,10 @@
public static void assertIs(final SQLCaseAssertContext assertContext,
final DeleteStatement actual, final DeleteStatementTestCase expected) {
assertTable(assertContext, actual, expected);
assertWhereClause(assertContext, actual, expected);
- assertOrderByClause(assertContext, actual, expected);
- assertLimitClause(assertContext, actual, expected);
+ if (actual instanceof MySQLStatement) {
+ assertOrderByClause(assertContext, (MySQLDeleteStatement) actual,
expected);
+ assertLimitClause(assertContext, (MySQLDeleteStatement) actual,
expected);
+ }
Review comment:
> It is an optional item. Just from my glance, my feeling is that it is
better to gather this judgment and handling detail into a function.
It is a good idea. 👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
