jingshanglu commented on a change in pull request #7476:
URL: https://github.com/apache/shardingsphere/pull/7476#discussion_r489904704
##########
File path:
shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-rewrite/src/main/java/org/apache/shardingsphere/sharding/rewrite/token/pojo/ProjectionsToken.java
##########
@@ -18,26 +18,29 @@
package org.apache.shardingsphere.sharding.rewrite.token.pojo;
import org.apache.shardingsphere.infra.rewrite.sql.token.pojo.Attachable;
+import org.apache.shardingsphere.infra.rewrite.sql.token.pojo.RouteUnitAware;
import org.apache.shardingsphere.infra.rewrite.sql.token.pojo.SQLToken;
+import org.apache.shardingsphere.infra.route.context.RouteUnit;
import java.util.Collection;
+import java.util.Map;
/**
* Projections token.
*/
-public final class ProjectionsToken extends SQLToken implements Attachable {
+public final class ProjectionsToken extends SQLToken implements Attachable,
RouteUnitAware {
- private final Collection<String> projections;
+ private final Map<RouteUnit, Collection<String>> projections;
- public ProjectionsToken(final int startIndex, final Collection<String>
projections) {
+ public ProjectionsToken(final int startIndex, final Map<RouteUnit,
Collection<String>> projections) {
Review comment:
The original struct is `Collection<String> projections`,it's a list of
rewrited derived projection string,such as `order by`, how about add some
comments?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
