wenweibin opened a new pull request #7546:
URL: https://github.com/apache/shardingsphere/pull/7546


   Fixes #6661 
   
   Changes proposed in this pull request:
   - **AbstractUnsupportedOperationStatement:** delete `getFetchDirection` and 
`setFetchDirection` method
   - **AbstractStatementAdapter:**  add field `fecthDirection`; add the 
implementation of `getFetchDirection` and `setFetchDirection` method.
    The setting of the `setFetchDirection` are invalid for many DB drivers,such 
as MySQL,H2,`getFetchDirection` always return 1000. Instead of returning 
directly the `getFetchDirection` result of the first underlying Statement, I 
think adding a field  named `fecthDirection` is a better choice , which ensures 
that the getter and setter of `fetchDirection`are consistent in  ShardingSphere.
   - **CircuitBreakerStatement:** add the implementation of `getFetchDirection` 
and `setFetchDirection` method.
   - **UnsupportedOperationStatementTest:** delete `assertGetFetchDirection` 
and `assertSetFetchDirection`
   - **StatementAdapterTest:** add the `assertSetFetchDirection` and 
`assertFetchDirection` method
   This PR is to solve the problem in issue 6661.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to