tristaZero commented on issue #7471:
URL: https://github.com/apache/shardingsphere/issues/7471#issuecomment-699755861
Hi @johnny2002,
Thanks for your detailed design doc. :)
Here are some of my thoughts. Welcome your review.
- `dataSourceTemplates`
This configuration seems clear, so I suppose we can first start with it. As
you know, ShardingSphere is an extensive map needing more effort for you to
explore so that we could start this journey by this work first. Otherwise, you
have to face a considerable challenge. **One tip I need to emphasize** that I
wish this item is optional, i.e., if there are no many data sources, users
could configure the whole props for data sources one by one.
- `tables`-1
```yaml
rules:
- !SHARDING
shardingTables:
- #Sample1: all tables Sharding by item_id should be under this group
tables: t_order, t_order_item
```
I prefer to group tables having the same configuration! However, our 5.x
release is coming soon, and it looks your changes will have a significant
impact on the API. I am concerned that it will confuse users a lot. Hence, do
you think we could have slightly smaller changes for them? But please take it
easy. We could first consider the change for `dataSources` and put off this one
later.
- `table`-1
```yaml
rules:
- !SHARDING
tables:
template_item_id:
t_order:
```
IMO, this example will confuse users, since `template_item_id ` differ from
`t_order`, doesn't it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
