[GitHub] [shardingsphere-elasticjob] codecov-io commented on pull request #1548: Redesign SPI factory to make them into one class (#1537)

Fri, 09 Oct 2020 06:52:36 -0700 


codecov-io commented on pull request #1548:
URL: 
https://github.com/apache/shardingsphere-elasticjob/pull/1548#issuecomment-705930074


   # 
[Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1548?src=pr&el=h1)
 Report
   > Merging 
[#1548](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1548?src=pr&el=desc)
 into 
[master](https://codecov.io/gh/apache/shardingsphere-elasticjob/commit/11532014e40561ea4bb46e93a2592e5b072a6f8c?el=desc)
 will **decrease** coverage by `0.20%`.
   > The diff coverage is `62.06%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1548/graphs/tree.svg?width=650&height=150&src=pr&token=8ZMVc4Yo4Z)](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1548?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1548      +/-   ##
   ============================================
   - Coverage     85.30%   85.10%   -0.21%     
   + Complexity      102      101       -1     
   ============================================
     Files           247      247              
     Lines          5676     5685       +9     
     Branches        890      892       +2     
   ============================================
   - Hits           4842     4838       -4     
   - Misses          524      531       +7     
   - Partials        310      316       +6     
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1548?src=pr&el=tree)
 | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...cjob/infra/listener/ElasticJobListenerFactory.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1548/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1pbmZyYS9lbGFzdGljam9iLWluZnJhLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZWxhc3RpY2pvYi9pbmZyYS9saXN0ZW5lci9FbGFzdGljSm9iTGlzdGVuZXJGYWN0b3J5LmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[.../elasticjob/infra/spi/ElasticJobServiceLoader.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1548/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1pbmZyYS9lbGFzdGljam9iLWluZnJhLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZWxhc3RpY2pvYi9pbmZyYS9zcGkvRWxhc3RpY0pvYlNlcnZpY2VMb2FkZXIuamF2YQ==)
 | `34.37% <52.63%> (+34.37%)` | `0.00 <0.00> (ø)` | |
   | 
[...asticjob/error/handler/JobErrorHandlerFactory.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1548/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1lcnJvci1oYW5kbGVyL2VsYXN0aWNqb2ItZXJyb3ItaGFuZGxlci10eXBlL2VsYXN0aWNqb2ItZXJyb3ItaGFuZGxlci1nZW5lcmFsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2Vycm9yL2hhbmRsZXIvSm9iRXJyb3JIYW5kbGVyRmFjdG9yeS5qYXZh)
 | `100.00% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...a/handler/sharding/JobShardingStrategyFactory.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1548/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1pbmZyYS9lbGFzdGljam9iLWluZnJhLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZWxhc3RpY2pvYi9pbmZyYS9oYW5kbGVyL3NoYXJkaW5nL0pvYlNoYXJkaW5nU3RyYXRlZ3lGYWN0b3J5LmphdmE=)
 | `100.00% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...r/threadpool/JobExecutorServiceHandlerFactory.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1548/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1pbmZyYS9lbGFzdGljam9iLWluZnJhLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZWxhc3RpY2pvYi9pbmZyYS9oYW5kbGVyL3RocmVhZHBvb2wvSm9iRXhlY3V0b3JTZXJ2aWNlSGFuZGxlckZhY3RvcnkuamF2YQ==)
 | `100.00% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...e/shardingsphere/elasticjob/infra/env/IpUtils.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1548/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1pbmZyYS9lbGFzdGljam9iLWluZnJhLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZWxhc3RpY2pvYi9pbmZyYS9lbnYvSXBVdGlscy5qYXZh)
 | `60.00% <0.00%> (-4.62%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...ticjob/lite/internal/snapshot/SnapshotService.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1548/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvaW50ZXJuYWwvc25hcHNob3QvU25hcHNob3RTZXJ2aWNlLmphdmE=)
 | `80.95% <0.00%> (-1.59%)` | `1.00% <0.00%> (ø%)` | |
   | 
[...sticjob/reg/zookeeper/ZookeeperRegistryCenter.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1548/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1pbmZyYS9lbGFzdGljam9iLXJlZ2lzdHJ5LWNlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZWxhc3RpY2pvYi9yZWcvem9va2VlcGVyL1pvb2tlZXBlclJlZ2lzdHJ5Q2VudGVyLmphdmE=)
 | `72.44% <0.00%> (-0.79%)` | `32.00% <0.00%> (-1.00%)` | |
   
   ------
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1548?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1548?src=pr&el=footer).
 Last update 
[1153201...3f393fc](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1548?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to