Technoboy- commented on a change in pull request #1550:
URL:
https://github.com/apache/shardingsphere-elasticjob/pull/1550#discussion_r503647207
##########
File path:
elasticjob-error-handler/elasticjob-error-handler-type/elasticjob-error-handler-dingtalk/src/main/java/org/apache/shardingsphere/elasticjob/error/handler/dingtalk/DingtalkConfiguration.java
##########
@@ -33,4 +35,17 @@
private final Integer connectTimeout;
private final Integer readTimeout;
+
+ /**
+ * Get dingtalk config.
+ *
+ * @param props props
+ * @return dingtalk config.
+ */
+ public static DingtalkConfiguration getByProps(final Properties props) {
Review comment:
dingtalk.webhook，dingtalk.keyword and dingtalk.xxx.
It' better to use a constant field for this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
