johnny2002 commented on pull request #7751:
URL: https://github.com/apache/shardingsphere/pull/7751#issuecomment-709688792
> Hello, @johnny2002 thanks a lot for contribution.
> As a team discussion for configuration design, common configured
parameters will be removed from current version.
> So, we need close this pr instead of merging it. Maybe someday we relaunch
the common configration and template functionalities in our ecosystem projects.
> But now let's move on.
@kimmking One more thing I wanna remind you is that, the new template style
datasource configuration also compatible with no template style. e.g. both the
following styles are compatible.
``` yaml
dataSources:
template1:
type: com.zaxxer.hikari.HikariDataSource
driverClassName: org.h2.Driver
username: root
password:
maximumPoolSize: 2
isTemplate: true #indicate this is a template, not a concrete datasource
ds_0:
template: template1 #inherit properties from datasource "template1"
jdbc-url: jdbc:h2:mem:core
maximumPoolSize: 5 #override the value "2" from "template1"
ds_1:
template: template1
jdbc-Url: jdbc:h2:mem:core
```
or
```yaml
dataSources:
ds_0:
type: com.zaxxer.hikari.HikariDataSource
driverClassName: org.h2.Driver
username: root
password:
maximumPoolSize: 2
jdbc-url: jdbc:h2:mem:core
maximumPoolSize: 5 #override the value "2" from "template1"
ds_1:
type: com.zaxxer.hikari.HikariDataSource
driverClassName: org.h2.Driver
username: root
password:
maximumPoolSize: 2
jdbc-Url: jdbc:h2:mem:core
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
