[shardingsphere-elasticjob] branch master updated: Add todo to default value (#1600)

[zhangliang]

This is an automated email from the ASF dual-hosted git repository.

zhangliang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere-elasticjob.git


The following commit(s) were added to refs/heads/master by this push:
     new dc25797  Add todo to default value (#1600)
dc25797 is described below

commit dc25797275052f4519e7c59331be295bb3ee9d44
Author: Liang Zhang <terrym...@163.com>
AuthorDate: Mon Oct 19 19:29:09 2020 +0800

    Add todo to default value (#1600)
---
 .../elasticjob/error/handler/dingtalk/DingtalkConfiguration.java     | 4 +++-
 .../elasticjob/error/handler/email/EmailConfiguration.java           | 5 ++++-
 .../elasticjob/error/handler/wechat/WechatConfiguration.java         | 2 ++
 3 files changed, 9 insertions(+), 2 deletions(-)

diff --git 
a/elasticjob-error-handler/elasticjob-error-handler-type/elasticjob-error-handler-dingtalk/src/main/java/org/apache/shardingsphere/elasticjob/error/handler/dingtalk/DingtalkConfiguration.java
 
b/elasticjob-error-handler/elasticjob-error-handler-type/elasticjob-error-handler-dingtalk/src/main/java/org/apache/shardingsphere/elasticjob/error/handler/dingtalk/DingtalkConfiguration.java
index 60ec904..f97b861 100644
--- 
a/elasticjob-error-handler/elasticjob-error-handler-type/elasticjob-error-handler-dingtalk/src/main/java/org/apache/shardingsphere/elasticjob/error/handler/dingtalk/DingtalkConfiguration.java
+++ 
b/elasticjob-error-handler/elasticjob-error-handler-type/elasticjob-error-handler-dingtalk/src/main/java/org/apache/shardingsphere/elasticjob/error/handler/dingtalk/DingtalkConfiguration.java
@@ -34,8 +34,10 @@ public final class DingtalkConfiguration implements 
ErrorHandlerConfiguration {
     
     private final String secret;
     
+    // TODO default value is 3000
     private final int connectTimeoutMillisecond;
-    
+
+    // TODO default value is 5000
     private final int readTimeoutMillisecond;
     
     @Override
diff --git 
a/elasticjob-error-handler/elasticjob-error-handler-type/elasticjob-error-handler-email/src/main/java/org/apache/shardingsphere/elasticjob/error/handler/email/EmailConfiguration.java
 
b/elasticjob-error-handler/elasticjob-error-handler-type/elasticjob-error-handler-email/src/main/java/org/apache/shardingsphere/elasticjob/error/handler/email/EmailConfiguration.java
index 00e3649..892e8fc 100644
--- 
a/elasticjob-error-handler/elasticjob-error-handler-type/elasticjob-error-handler-email/src/main/java/org/apache/shardingsphere/elasticjob/error/handler/email/EmailConfiguration.java
+++ 
b/elasticjob-error-handler/elasticjob-error-handler-type/elasticjob-error-handler-email/src/main/java/org/apache/shardingsphere/elasticjob/error/handler/email/EmailConfiguration.java
@@ -36,8 +36,10 @@ public final class EmailConfiguration implements 
ErrorHandlerConfiguration {
     
     private final String password;
     
+    // TODO default value is true
     private final boolean useSsl;
     
+    // TODO default value is ElasticJob error message
     private final String subject;
     
     private final String from;
@@ -47,7 +49,8 @@ public final class EmailConfiguration implements 
ErrorHandlerConfiguration {
     private final String cc;
     
     private final String bcc;
-    
+
+    // TODO default value is false
     private final boolean debug;
     
     @Override
diff --git 
a/elasticjob-error-handler/elasticjob-error-handler-type/elasticjob-error-handler-wechat/src/main/java/org/apache/shardingsphere/elasticjob/error/handler/wechat/WechatConfiguration.java
 
b/elasticjob-error-handler/elasticjob-error-handler-type/elasticjob-error-handler-wechat/src/main/java/org/apache/shardingsphere/elasticjob/error/handler/wechat/WechatConfiguration.java
index 04f59bd..0604533 100644
--- 
a/elasticjob-error-handler/elasticjob-error-handler-type/elasticjob-error-handler-wechat/src/main/java/org/apache/shardingsphere/elasticjob/error/handler/wechat/WechatConfiguration.java
+++ 
b/elasticjob-error-handler/elasticjob-error-handler-type/elasticjob-error-handler-wechat/src/main/java/org/apache/shardingsphere/elasticjob/error/handler/wechat/WechatConfiguration.java
@@ -30,8 +30,10 @@ public final class WechatConfiguration implements 
ErrorHandlerConfiguration {
     
     private final String webhook;
     
+    // TODO default value is 3000
     private final int connectTimeoutMillisecond;
     
+    // TODO default value is 3000
     private final int readTimeoutMillisecond;
     
     @Override