tristaZero commented on a change in pull request #7853:
URL: https://github.com/apache/shardingsphere/pull/7853#discussion_r508197439
##########
File path:
shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-route/src/main/java/org/apache/shardingsphere/sharding/route/engine/validator/ddl/impl/ShardingCreateProcedureStatementValidator.java
##########
@@ -42,7 +44,9 @@ public void preValidate(final ShardingRule shardingRule,
final SQLStatementConte
routineBodySegment.ifPresent(routineBody -> {
TableExtractor extractor = new TableExtractor();
validateTableNotExist(metaData,
extractor.extractNotExistTableFromRoutineBody(routineBody));
- validateShardingTable(metaData,
extractor.extractExistTableFromRoutineBody(routineBody));
+ Collection<SimpleTableSegment> existTables =
extractor.extractExistTableFromRoutineBody(routineBody);
+ validateShardingTable(metaData, existTables);
Review comment:
Hi @strongduanmu
I know this PR is a time-consuming work, Very appreciated your initiative!
`Create procedure, function, view` is a
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
