This is an automated email from the ASF dual-hosted git repository.

zhangliang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere-elasticjob.git


The following commit(s) were added to refs/heads/master by this push:
     new 223374b  Add null check in validateJobErrorHandlerProperties (#1682)
223374b is described below

commit 223374b7f41f28476df8eec81e3edf879752df10
Author: Liang Zhang <[email protected]>
AuthorDate: Fri Oct 30 15:01:48 2020 +0800

    Add null check in validateJobErrorHandlerProperties (#1682)
---
 .../elasticjob/lite/internal/schedule/JobScheduler.java             | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git 
a/elasticjob-lite/elasticjob-lite-core/src/main/java/org/apache/shardingsphere/elasticjob/lite/internal/schedule/JobScheduler.java
 
b/elasticjob-lite/elasticjob-lite-core/src/main/java/org/apache/shardingsphere/elasticjob/lite/internal/schedule/JobScheduler.java
index 7f9a362..57905b4 100644
--- 
a/elasticjob-lite/elasticjob-lite-core/src/main/java/org/apache/shardingsphere/elasticjob/lite/internal/schedule/JobScheduler.java
+++ 
b/elasticjob-lite/elasticjob-lite-core/src/main/java/org/apache/shardingsphere/elasticjob/lite/internal/schedule/JobScheduler.java
@@ -119,8 +119,10 @@ public final class JobScheduler {
     }
     
     private void validateJobErrorHandlerProperties() {
-        
ElasticJobServiceLoader.newTypedServiceInstance(JobErrorHandlerPropertiesValidator.class,
 jobConfig.getJobErrorHandlerType(), jobConfig.getProps())
-                .ifPresent(validator -> 
validator.validate(jobConfig.getProps()));
+        if (null != jobConfig.getJobErrorHandlerType()) {
+            
ElasticJobServiceLoader.newTypedServiceInstance(JobErrorHandlerPropertiesValidator.class,
 jobConfig.getJobErrorHandlerType(), jobConfig.getProps())
+                    .ifPresent(validator -> 
validator.validate(jobConfig.getProps()));
+        }
     }
     
     private void setGuaranteeServiceForElasticJobListeners(final 
CoordinatorRegistryCenter regCenter, final Collection<ElasticJobListener> 
elasticJobListeners) {

Reply via email to