jingshanglu commented on a change in pull request #8077:
URL: https://github.com/apache/shardingsphere/pull/8077#discussion_r519524261
##########
File path:
shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-mysql/src/main/antlr4/imports/mysql/DMLStatement.g4
##########
@@ -105,11 +105,11 @@ singleTableClause
;
multipleTablesClause
- : tableAliasRefList FROM tableReferences | FROM tableAliasRefList USING
tableReferences
+ : multipleTableNames FROM tableReferences | FROM multipleTableNames USING
tableReferences
;
multipleTableNames
- : tableName DOT_ASTERISK_? (COMMA_ tableName DOT_ASTERISK_?)*
+ : tableIdentOptWild (COMMA_ tableIdentOptWild)*
;
Review comment:
> @jingshanglu I think `tableLockingList` should be part of
`lockClause`. but this change need more test case . so I will keep
`tableLockingList` and not modify `lockClause` this time. what do you think ?
@lwtdev I checked the actual grammar rules([MySQL Source
Code](https://github.com/mysql/mysql-server/blob/8.0/sql/sql_yacc.yy)), the
`lockClause` rule should like this:
```
lockClause
: FOR lockStrength tableLockingList? lockedRowAction?
| LOCK IN SHARE MODE
;
```
Change it by the way.
And then can you create PR to master branch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
