strongduanmu commented on a change in pull request #8105:
URL: https://github.com/apache/shardingsphere/pull/8105#discussion_r520288100
##########
File path:
shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-route/src/test/java/org/apache/shardingsphere/sharding/route/engine/type/standard/SubqueryRouteTest.java
##########
@@ -149,16 +149,6 @@ public void assertSubqueryForBinding() {
assertRoute(sql, parameters);
}
- @Test(expected = IllegalStateException.class)
- public void assertSubqueryWithoutHint() {
- List<Object> parameters = new LinkedList<>();
- parameters.add(1);
- parameters.add(2);
- parameters.add(5);
- String sql = "select count(*) from t_hint_test where user_id = (select
t_hint_test from t_hint_test where user_id in (?,?,?)) ";
- assertRoute(sql, parameters);
- }
-
Review comment:
> @strongduanmu Why delete this UT?
@jingshanglu After we support sub query route without sharding key, this
exception case will not exist.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
