strongduanmu commented on a change in pull request #8160:
URL: https://github.com/apache/shardingsphere/pull/8160#discussion_r525110188
##########
File path:
shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/common/segment/dml/predicate/LockSegment.java
##########
@@ -32,4 +36,7 @@
private final int startIndex;
private final int stopIndex;
+
+ @Setter
+ private List<SimpleTableSegment> forTables;
Review comment:
> In fact, I thought pre-initialized it at the beginning. But the
`forTables` is empty most time. And I also found some code example in
Shardingshpere project that keep list as null default. So I am also a little
confused at it.
> But I also think pre-initialization is easier to read and use.
>
> I want to keep the same style with the project, so what is the style of
the project? 😀
@lwtdev I found two common coding styles, one is to use construction method
to initialize the collection, such as the `values` ​​variable in
`InsertValuesSegment`, and the other is to pre-initialize directly in the
class, such as the `variableAssigns` variable in `SetStatement`. 😀
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
