tristaZero commented on a change in pull request #8622:
URL: https://github.com/apache/shardingsphere/pull/8622#discussion_r544771620
##########
File path:
shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/mysql/visitor/format/impl/MySQLFormatSQLVisitor.java
##########
@@ -68,24 +69,41 @@
import
org.apache.shardingsphere.sql.parser.autogen.MySQLStatementParser.WhereClauseContext;
import
org.apache.shardingsphere.sql.parser.autogen.MySQLStatementParser.WithClauseContext;
+import java.util.Properties;
+
/**
* MySQL Format SQL visitor for MySQL.
*/
+@NoArgsConstructor
@Getter
@Setter
public abstract class MySQLFormatSQLVisitor extends
MySQLStatementBaseVisitor<String> {
private StringBuilder result = new StringBuilder();
- private boolean uperCase = true;
+ private boolean upperCase = true;
private boolean parameterized = true;
private int indentCount;
private int lines;
- private final int projectionsCountOfLine = 3;
+ private int projectionsCountOfLine = 3;
+
+ MySQLFormatSQLVisitor(final Properties props) {
+ if (null != props) {
Review comment:
Is it possible to remove this `if (null != props)`?
##########
File path:
shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/mysql/visitor/statement/impl/MySQLStatementSQLVisitor.java
##########
@@ -184,15 +185,20 @@
import java.util.Collections;
import java.util.LinkedList;
import java.util.List;
+import java.util.Properties;
/**
* MySQL Statement SQL visitor.
*/
+@NoArgsConstructor
@Getter(AccessLevel.PROTECTED)
public abstract class MySQLStatementSQLVisitor extends
MySQLStatementBaseVisitor<ASTNode> {
private int currentParameterIndex;
+ MySQLStatementSQLVisitor(final Properties props) {
Review comment:
public class?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
