tristaZero commented on a change in pull request #8665: URL: https://github.com/apache/shardingsphere/pull/8665#discussion_r547156878
########## File path: shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/common/SqlStats.java ########## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.shardingsphere.sql.parser.sql.common; + +import lombok.Getter; +import org.apache.shardingsphere.sql.parser.sql.common.segment.dml.column.ColumnSegment; +import org.apache.shardingsphere.sql.parser.sql.common.segment.generic.table.SimpleTableSegment; + +import java.util.LinkedHashMap; +import java.util.Map; + +@Getter +public class SqlStats { Review comment: Plz define it as final ########## File path: shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/mysql/visitor/MySQLSQLStatVisitor.java ########## @@ -0,0 +1,152 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.shardingsphere.sql.parser.mysql.visitor; + +import lombok.Getter; +import lombok.Setter; +import org.antlr.v4.runtime.tree.TerminalNode; +import org.apache.shardingsphere.sql.parser.autogen.MySQLStatementBaseVisitor; +import org.apache.shardingsphere.sql.parser.autogen.MySQLStatementParser.AliasContext; +import org.apache.shardingsphere.sql.parser.autogen.MySQLStatementParser.ColumnDefinitionContext; +import org.apache.shardingsphere.sql.parser.autogen.MySQLStatementParser.ColumnRefContext; +import org.apache.shardingsphere.sql.parser.autogen.MySQLStatementParser.IdentifierContext; +import org.apache.shardingsphere.sql.parser.autogen.MySQLStatementParser.InsertContext; +import org.apache.shardingsphere.sql.parser.autogen.MySQLStatementParser.OwnerContext; +import org.apache.shardingsphere.sql.parser.autogen.MySQLStatementParser.TableFactorContext; +import org.apache.shardingsphere.sql.parser.autogen.MySQLStatementParser.TableNameContext; +import org.apache.shardingsphere.sql.parser.autogen.MySQLStatementParser.TableWildContext; +import org.apache.shardingsphere.sql.parser.sql.common.SqlStats; +import org.apache.shardingsphere.sql.parser.sql.common.segment.dml.column.ColumnSegment; +import org.apache.shardingsphere.sql.parser.sql.common.segment.generic.AliasSegment; +import org.apache.shardingsphere.sql.parser.sql.common.segment.generic.OwnerSegment; +import org.apache.shardingsphere.sql.parser.sql.common.segment.generic.table.SimpleTableSegment; +import org.apache.shardingsphere.sql.parser.sql.common.segment.generic.table.TableNameSegment; +import org.apache.shardingsphere.sql.parser.sql.common.value.identifier.IdentifierValue; + +/** + * MySQL SQL Stats visitor for MySQL. + */ +@Getter +@Setter +public final class MySQLSQLStatVisitor extends MySQLStatementBaseVisitor<SqlStats> { + + private SqlStats sqlStats = new SqlStats(); Review comment: final? ########## File path: shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/common/SqlStats.java ########## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.shardingsphere.sql.parser.sql.common; + +import lombok.Getter; +import org.apache.shardingsphere.sql.parser.sql.common.segment.dml.column.ColumnSegment; +import org.apache.shardingsphere.sql.parser.sql.common.segment.generic.table.SimpleTableSegment; + +import java.util.LinkedHashMap; +import java.util.Map; + +@Getter +public class SqlStats { + + private Map<String, SimpleTableSegment> tables = new LinkedHashMap<>(); + + private Map<Integer, ColumnSegment> columns = new LinkedHashMap<>(); + + private int hashCode(final ColumnSegment column) { + StringBuilder columString = new StringBuilder(); + if (column.getOwner().isPresent()) { + columString.append(column.getOwner().get().getIdentifier().getValue()); + } + columString.append(column.getIdentifier().getValue()); + return columString.toString().hashCode(); + } + + /** + * add table to tables. + * @param tableSegment SimpleTableSegment. + */ + public void addTable(final SimpleTableSegment tableSegment) { + if (!tables.containsKey(tableSegment.getTableName().getIdentifier().getValue())) { + tables.put(tableSegment.getTableName().getIdentifier().getValue(), tableSegment); + } + } + + /** + * add column to columns. + * @param column ColumnSegment. + */ + public void addColumn(final ColumnSegment column) { + int columnHashcode = hashCode(column); Review comment: `HashCode` is supposed to be overwrite in `ColumnSegment`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
