tristaZero commented on a change in pull request #8894:
URL: https://github.com/apache/shardingsphere/pull/8894#discussion_r553345769
##########
File path:
shardingsphere-governance/shardingsphere-governance-core/src/main/java/org/apache/shardingsphere/governance/core/config/ConfigCenter.java
##########
@@ -113,6 +114,15 @@ public void persistGlobalConfiguration(final
DefaultAuthentication authenticatio
public synchronized void renew(final DataSourcePersistEvent event) {
addDataSourceConfigurations(event.getSchemaName(),
event.getDataSourceConfigurations());
}
+
+ /**
+ * change data source configurations.
Review comment:
change - > Change
##########
File path:
shardingsphere-db-protocol/shardingsphere-db-protocol-core/src/main/java/org/apache/shardingsphere/db/protocol/error/CommonErrorCode.java
##########
@@ -32,6 +32,10 @@
SHARDING_TABLE_RULES_NOT_EXISTED(11001, "C11001", "Sharding table rule %s
is not exist."),
TABLES_IN_USED(11002, "C11002", "Can not drop rule, tables %s in the rule
are still in used."),
+
+ RESOURCE_IN_USED(11003, "C11003", "Can not drop resources, resources %s in
the rule are still in used."),
+
+ RESOURCE_NOT_EXIST(11004, "C11004", "Can not drop resources, resources %s
not exist."),
Review comment:
resources %s do not exist.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
