terrymanu commented on a change in pull request #8937:
URL: https://github.com/apache/shardingsphere/pull/8937#discussion_r553879165
##########
File path:
shardingsphere-proxy/shardingsphere-proxy-backend/src/main/java/org/apache/shardingsphere/proxy/backend/text/distsql/rql/impl/DataSourcesQueryBackendHandler.java
##########
@@ -42,6 +46,8 @@
private Map<String, DataSourceParameter> dataSourceParameterMap;
+ private String schemaName;
Review comment:
It is not good a design for use global field which assigned out of the
constructor.
Can you consider about improve it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
