terrymanu commented on a change in pull request #8906:
URL: https://github.com/apache/shardingsphere/pull/8906#discussion_r554700933
##########
File path:
shardingsphere-infra/shardingsphere-infra-common/src/main/java/org/apache/shardingsphere/infra/database/metadata/dialect/PostgreSQLDataSourceMetaData.java
##########
@@ -41,7 +41,7 @@
private final String schema;
- private final Pattern pattern =
Pattern.compile("jdbc:postgresql://([\\w\\-\\.]+):?([0-9]*)/([\\w\\-]+)",
Pattern.CASE_INSENSITIVE);
+ private final Pattern pattern =
Pattern.compile("jdbc:postgresql://([\\w\\-\\.]+):?([0-9]*),?.*?/([\\w\\-]+)?\\S*",
Pattern.CASE_INSENSITIVE);
Review comment:
What is the different for use multiple hosts and replica-query rule?
We need to discuss the production design here. It is better to use same way
for same feature. I prefer use replica-query rule to deal with all master-slave
scenarios.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
