Liangda-w commented on a change in pull request #9740:
URL: https://github.com/apache/shardingsphere/pull/9740#discussion_r599156983
##########
File path:
shardingsphere-sql-parser/shardingsphere-sql-parser-test/src/main/java/org/apache/shardingsphere/test/sql/parser/parameterized/asserts/statement/ddl/DDLStatementAssert.java
##########
@@ -72,6 +75,8 @@ public static void assertIs(final SQLCaseAssertContext
assertContext, final DDLS
AlterIndexStatementAssert.assertIs(assertContext,
(AlterIndexStatement) actual, (AlterIndexStatementTestCase) expected);
} else if (actual instanceof DropIndexStatement) {
DropIndexStatementAssert.assertIs(assertContext,
(DropIndexStatement) actual, (DropIndexStatementTestCase) expected);
+ } else if (actual instanceof OracleAlterSynonymStatement) {
Review comment:
Hi @tristaZero @wgy8283335
If we are only interested in table-related and index-related Statements,
then we probably don't need to test `OracleAlterSynonymStatement`.
But when I looked at dcl and here basically all statements like for example
`AlterRoleStatement`, `AlterUserStatement` are tested. So I thought that we
also need it for `OracleAlterSynonymStatement`.
Should I delete it or keep it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
