terrymanu commented on a change in pull request #9725:
URL: https://github.com/apache/shardingsphere/pull/9725#discussion_r600152279



##########
File path: 
shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-fixture/Dockerfile
##########
@@ -18,10 +18,22 @@
 FROM openjdk:8-jdk-alpine
 
 ARG APP_NAME
-ENV WAIT_VERSION 2.7.2
 
 ADD target/${APP_NAME}.tar.gz /opt
-ADD 
https://github.com/ufoscout/docker-compose-wait/releases/download/$WAIT_VERSION/wait
 /wait
-RUN chmod +x /wait
 RUN mv /opt/${APP_NAME} /opt/shardingsphere-proxy
-ENTRYPOINT /wait && /opt/shardingsphere-proxy/bin/start.sh && tail -f 
/opt/shardingsphere-proxy/logs/stdout.log
+
+# ADD ./target/shardingsphere-agent.tar.gz 
/opt/shardingsphere-proxy/shardingsphere-agent
+
+EXPOSE 3307
+EXPOSE 3308
+
+#HEALTHCHECK --interval=1ms --timeout=60s --retries=1 \
+#    CMD (tail -f -n200 /opt/shardingsphere-proxy/logs/stdout.log |grep -q 
"ShardingSphere-Proxy start success")

Review comment:
       It is better to remove temp codes




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to