tristaZero commented on a change in pull request #9924: URL: https://github.com/apache/shardingsphere/pull/9924#discussion_r606779310
########## File path: shardingsphere-infra/shardingsphere-infra-common/src/main/java/org/apache/shardingsphere/infra/metadata/auth/builder/loader/dialect/PostgreSQLPrivilegeLoader.java ########## @@ -0,0 +1,131 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.shardingsphere.infra.metadata.auth.builder.loader.dialect; + +import org.apache.shardingsphere.infra.metadata.auth.builder.loader.PrivilegeLoader; +import org.apache.shardingsphere.infra.metadata.auth.model.privilege.PrivilegeType; +import org.apache.shardingsphere.infra.metadata.auth.model.privilege.ShardingSpherePrivilege; +import org.apache.shardingsphere.infra.metadata.auth.model.privilege.database.SchemaPrivilege; +import org.apache.shardingsphere.infra.metadata.auth.model.privilege.database.TablePrivilege; +import org.apache.shardingsphere.infra.metadata.auth.model.user.ShardingSphereUser; + +import javax.sql.DataSource; +import java.sql.Connection; +import java.sql.ResultSet; +import java.sql.SQLException; +import java.sql.Statement; +import java.util.ArrayList; +import java.util.Collection; +import java.util.HashMap; +import java.util.LinkedHashMap; +import java.util.List; +import java.util.Map; +import java.util.stream.Collectors; + +/** + * PostgreSQL privilege loader. + */ +public final class PostgreSQLPrivilegeLoader implements PrivilegeLoader { + + private static final String TABLE_PRIVILEGE_SQL = "SELECT grantor, grantee, table_catalog, table_name, privilege_type, is_grantable from information_schema.table_privileges WHERE grantee IN (%s)"; + + @Override + public Map<ShardingSphereUser, ShardingSpherePrivilege> load(final Collection<ShardingSphereUser> users, final DataSource dataSource) throws SQLException { + Map<ShardingSphereUser, ShardingSpherePrivilege> result = new LinkedHashMap<>(); + users.forEach(user -> result.put(user, new ShardingSpherePrivilege())); + fillTablePrivilege(result, dataSource, users); + return result; + } + + private void fillTablePrivilege(final Map<ShardingSphereUser, ShardingSpherePrivilege> privileges, final DataSource dataSource, final Collection<ShardingSphereUser> users) throws SQLException { + Map<ShardingSphereUser, Map<String, Map<String, List<PrivilegeType>>>> privilegeCache = new HashMap<>(); + try (Connection connection = dataSource.getConnection()) { + Statement statement = connection.createStatement(); + try (ResultSet resultSet = statement.executeQuery(getTablePrivilegeSQL(users))) { + while (resultSet.next()) { + collectPrivilege(privilegeCache, resultSet); + } + } + } + fillTablePrivilege(privilegeCache, privileges); + } + + private void fillTablePrivilege(final Map<ShardingSphereUser, Map<String, Map<String, List<PrivilegeType>>>> privilegeCache, final Map<ShardingSphereUser, ShardingSpherePrivilege> privileges) { + for (ShardingSphereUser user : privilegeCache.keySet()) { + for (String db : privilegeCache.get(user).keySet()) { + for (String tableName : privilegeCache.get(user).get(db).keySet()) { + TablePrivilege tablePrivilege = new TablePrivilege(tableName, privilegeCache.get(user).get(db).get(tableName)); + ShardingSpherePrivilege privilege = privileges.get(user); + if (!privilege.getDatabasePrivilege().getSpecificPrivileges().containsKey(db)) { + privilege.getDatabasePrivilege().getSpecificPrivileges().put(db, new SchemaPrivilege(db)); + } + privilege.getDatabasePrivilege().getSpecificPrivileges().get(db).getSpecificPrivileges().put(tableName, tablePrivilege); + } + } + } + } + + private void collectPrivilege(final Map<ShardingSphereUser, Map<String, Map<String, List<PrivilegeType>>>> privilegeCache, final ResultSet resultSet) throws SQLException { + String db = resultSet.getString("table_catalog"); + String tableName = resultSet.getString("table_name"); + String privilegeType = resultSet.getString("privilege_type"); + Boolean hasPrivilege = resultSet.getBoolean("is_grantable"); + String grantee = resultSet.getString("grantee"); + if (hasPrivilege) { + privilegeCache + .computeIfAbsent(new ShardingSphereUser(grantee, "", ""), k -> new HashMap<>()) + .computeIfAbsent(db, k -> new HashMap<>()) + .computeIfAbsent(tableName, k -> new ArrayList<>()) + .add(getPrivilegeType(privilegeType)); + } + } + + private String getTablePrivilegeSQL(final Collection<ShardingSphereUser> users) { + String userList = users.stream().map(each -> each.getGrantee().getUsername()) + .collect(Collectors.joining(", ")); + return String.format(TABLE_PRIVILEGE_SQL, userList); + } + + private PrivilegeType getPrivilegeType(final String privilege) { + switch (privilege) { + case "SELECT": + return PrivilegeType.SELECT; + case "INSERT": + return PrivilegeType.INSERT; + case "UPDATE": + return PrivilegeType.UPDATE; + case "DELETE": + return PrivilegeType.DELETE; + case "CREATE": + return PrivilegeType.CREATE; + case "REFERENCES": + return PrivilegeType.REFERENCES; Review comment: How about `usage`, `connect` and others? If needed, you can add more types in `PrivilegeType`. ########## File path: shardingsphere-infra/shardingsphere-infra-common/src/main/java/org/apache/shardingsphere/infra/metadata/auth/builder/loader/dialect/PostgreSQLPrivilegeLoader.java ########## @@ -0,0 +1,131 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.shardingsphere.infra.metadata.auth.builder.loader.dialect; + +import org.apache.shardingsphere.infra.metadata.auth.builder.loader.PrivilegeLoader; +import org.apache.shardingsphere.infra.metadata.auth.model.privilege.PrivilegeType; +import org.apache.shardingsphere.infra.metadata.auth.model.privilege.ShardingSpherePrivilege; +import org.apache.shardingsphere.infra.metadata.auth.model.privilege.database.SchemaPrivilege; +import org.apache.shardingsphere.infra.metadata.auth.model.privilege.database.TablePrivilege; +import org.apache.shardingsphere.infra.metadata.auth.model.user.ShardingSphereUser; + +import javax.sql.DataSource; +import java.sql.Connection; +import java.sql.ResultSet; +import java.sql.SQLException; +import java.sql.Statement; +import java.util.ArrayList; +import java.util.Collection; +import java.util.HashMap; +import java.util.LinkedHashMap; +import java.util.List; +import java.util.Map; +import java.util.stream.Collectors; + +/** + * PostgreSQL privilege loader. + */ +public final class PostgreSQLPrivilegeLoader implements PrivilegeLoader { + + private static final String TABLE_PRIVILEGE_SQL = "SELECT grantor, grantee, table_catalog, table_name, privilege_type, is_grantable from information_schema.table_privileges WHERE grantee IN (%s)"; + + @Override + public Map<ShardingSphereUser, ShardingSpherePrivilege> load(final Collection<ShardingSphereUser> users, final DataSource dataSource) throws SQLException { + Map<ShardingSphereUser, ShardingSpherePrivilege> result = new LinkedHashMap<>(); + users.forEach(user -> result.put(user, new ShardingSpherePrivilege())); + fillTablePrivilege(result, dataSource, users); + return result; + } + + private void fillTablePrivilege(final Map<ShardingSphereUser, ShardingSpherePrivilege> privileges, final DataSource dataSource, final Collection<ShardingSphereUser> users) throws SQLException { + Map<ShardingSphereUser, Map<String, Map<String, List<PrivilegeType>>>> privilegeCache = new HashMap<>(); + try (Connection connection = dataSource.getConnection()) { + Statement statement = connection.createStatement(); + try (ResultSet resultSet = statement.executeQuery(getTablePrivilegeSQL(users))) { + while (resultSet.next()) { + collectPrivilege(privilegeCache, resultSet); + } + } + } + fillTablePrivilege(privilegeCache, privileges); + } + + private void fillTablePrivilege(final Map<ShardingSphereUser, Map<String, Map<String, List<PrivilegeType>>>> privilegeCache, final Map<ShardingSphereUser, ShardingSpherePrivilege> privileges) { + for (ShardingSphereUser user : privilegeCache.keySet()) { + for (String db : privilegeCache.get(user).keySet()) { + for (String tableName : privilegeCache.get(user).get(db).keySet()) { + TablePrivilege tablePrivilege = new TablePrivilege(tableName, privilegeCache.get(user).get(db).get(tableName)); + ShardingSpherePrivilege privilege = privileges.get(user); + if (!privilege.getDatabasePrivilege().getSpecificPrivileges().containsKey(db)) { + privilege.getDatabasePrivilege().getSpecificPrivileges().put(db, new SchemaPrivilege(db)); + } + privilege.getDatabasePrivilege().getSpecificPrivileges().get(db).getSpecificPrivileges().put(tableName, tablePrivilege); + } + } + } + } + + private void collectPrivilege(final Map<ShardingSphereUser, Map<String, Map<String, List<PrivilegeType>>>> privilegeCache, final ResultSet resultSet) throws SQLException { + String db = resultSet.getString("table_catalog"); + String tableName = resultSet.getString("table_name"); + String privilegeType = resultSet.getString("privilege_type"); + Boolean hasPrivilege = resultSet.getBoolean("is_grantable"); + String grantee = resultSet.getString("grantee"); + if (hasPrivilege) { + privilegeCache + .computeIfAbsent(new ShardingSphereUser(grantee, "", ""), k -> new HashMap<>()) + .computeIfAbsent(db, k -> new HashMap<>()) + .computeIfAbsent(tableName, k -> new ArrayList<>()) + .add(getPrivilegeType(privilegeType)); + } + } + + private String getTablePrivilegeSQL(final Collection<ShardingSphereUser> users) { + String userList = users.stream().map(each -> each.getGrantee().getUsername()) + .collect(Collectors.joining(", ")); + return String.format(TABLE_PRIVILEGE_SQL, userList); + } + + private PrivilegeType getPrivilegeType(final String privilege) { + switch (privilege) { + case "SELECT": + return PrivilegeType.SELECT; + case "INSERT": + return PrivilegeType.INSERT; + case "UPDATE": + return PrivilegeType.UPDATE; + case "DELETE": + return PrivilegeType.DELETE; + case "CREATE": + return PrivilegeType.CREATE; + case "REFERENCES": + return PrivilegeType.REFERENCES; Review comment: Can we transfer `Role Attributes` (login,superuser,createdb,createrole,replication,passwod,inherit) and put them info this privilege system? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
