tristaZero commented on a change in pull request #9940:
URL: https://github.com/apache/shardingsphere/pull/9940#discussion_r609416919
##########
File path:
shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-oracle/src/main/antlr4/imports/oracle/DDLStatement.g4
##########
@@ -919,3 +919,31 @@ flashbackArchiveClause
alterSynonym
: ALTER PUBLIC? SYNONYM (schemaName DOT_)? synonymName (COMPILE |
EDITIONABLE | NONEDITIONABLE)
;
+
+alterTablePartition
+ : addTablePartition | dropTablePartition
+ ;
+
+addTablePartition
+ : ADD (addRangePartitionClause | addListPartitionClause)
+ ;
+
+addRangePartitionClause
+ : PARTITION partitionName? rangeValuesClause tablePartitionDescription
+ ((LP_? rangeSubpartitionDesc (COMMA_ rangeSubpartitionDesc)* |
listSubpartitionDesc (COMMA_ listSubpartitionDesc)* | individualHashSubparts
(COMMA_ individualHashSubparts)* RP_?)
+ | hashSubpartitionQuantity)?
+ ;
+
+addListPartitionClause
+ : PARTITION partitionName? listValuesClause tablePartitionDescription
+ ((LP_? rangeSubpartitionDesc (COMMA_ rangeSubpartitionDesc)* |
listSubpartitionDesc (COMMA_ listSubpartitionDesc)* | individualHashSubparts
(COMMA_ individualHashSubparts)* RP_?)
+ | hashSubpartitionQuantity)?
+ ;
+
Review comment:
So
```
The addRangePartitionClause and addListPartitionClause are not fully
completed, below rules need to be done.
table_partition_description
external_part_subpart_data_props
update_index_clauses
```
Will these definitions be improved in the next PR?
It is not a complete grammar definition, is it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
