wgy8283335 commented on pull request #10016: URL: https://github.com/apache/shardingsphere/pull/10016#issuecomment-817231031
> Related #9694 > > Sorry for being late I noticed #9940 has already done some changes to fix this issue, thank you @zhujunxxxxx. Please allow me to finish the following changes: > > * Complete `drop_table_partition` of [ALTER TABLE](https://docs.oracle.com/en/database/oracle/oracle-database/19/sqlrf/ALTER-TABLE.html#GUID-552E7373-BF93-477D-9DA3-B2C9386F2877) and add corresponding test cases > * Fix `addColumnSpecification`, as brackets are necessary here > * Adjust `Literal.g4` for a clear separated definition for integer etc. > * In `BaseRule.g4` `partition` and `partitionName` are used exactly in the same way, for consistency I removed one of the duplicates > > Could you please review it :) @tristaZero @wgy8283335 Could you split the pr into 4 pull requests, as you mentioned that there mainly 4 changes in the pr? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
