tristaZero commented on a change in pull request #10011:
URL: https://github.com/apache/shardingsphere/pull/10011#discussion_r611155944
##########
File path:
shardingsphere-infra/shardingsphere-infra-common/src/main/java/org/apache/shardingsphere/infra/config/datasource/DataSourceValidator.java
##########
@@ -30,23 +31,23 @@
/**
* Validate.
*
- * @param dataSources data sources.
- * @return is valid or not
+ * @param dataSourceConfigurations map of data source configuration
+ * @return collection of invalid data sources
*/
- public boolean validate(final Map<String, DataSourceConfiguration>
dataSources) {
Review comment:
Do you think It is better to rename it as `getInvalidatedDataSources()`?
Or maybe we can pass one `DataSourceConfiguration` for validation (my
preference).
How do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
