[GitHub] [shardingsphere] tristaZero commented on a change in pull request #9929: Issue#9845.fix Binding tables using 'join .. on .. and column_x=?' or 'join .. on .. and cloumn_x in (?)' can not sharding correct.

[GitBox]

tristaZero commented on a change in pull request #9929:
URL: https://github.com/apache/shardingsphere/pull/9929#discussion_r611164213



##########
File path: 
shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-suite/src/test/resources/cases/dql/dql-integration-test-cases.xml
##########
@@ -19,378 +19,387 @@
     <test-case sql="SELECT 1 as a">
         <assertion expected-data-file="select_constant_without_table.xml" />
     </test-case>
-    

Review comment:
       Unit tests look good to me, but why are many lines modified?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org