tristaZero commented on a change in pull request #10006:
URL: https://github.com/apache/shardingsphere/pull/10006#discussion_r613987768
##########
File path:
shardingsphere-governance/shardingsphere-governance-core/src/main/java/org/apache/shardingsphere/governance/core/registry/RegistryCenter.java
##########
@@ -480,6 +482,19 @@ public synchronized void renew(final GrantStatementEvent
event) {
persistChangedPrivilege(event.getUsers());
}
+ /**
+ * Load children values.
+ *
+ * @param event get children request event.
+ */
+ @Subscribe
+ public void loadChildrenValues(final GetChildrenRequestEvent event) {
Review comment:
Why is it called `loadChildrenValues`? I suppose its named relevant with
`show process`, like `loadShowProcessData`, `loadShowProcessList`? And the
event name is the same case.
Actually, ShardingProxy does not know the detail of `registryCenter`, e.g.,
child node. What Proxy wants to do is to request its expected data.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
