ThanoshanMV commented on a change in pull request #10253: URL: https://github.com/apache/shardingsphere/pull/10253#discussion_r627141925
########## File path: shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-oracle/src/main/antlr4/imports/oracle/DDLStatement.g4 ########## @@ -1421,3 +1421,258 @@ leadCdbUriClause propertyClause : PROPERTY (SET | REMOVE) DEFAULT_CREDENTIAL EQ_ qualifiedCredentialName ; + +alterSystem + : ALTER SYSTEM alterSystemOption + ; + +alterSystemOption + : archiveLogClause + | checkpointClause + | checkDatafilesClause + | distributedRecovClauses + | flushClause + | endSessionClauses + | switchLogfileClause + | suspendResumeClause + | quiesceClauses + | rollingMigrationClauses + | rollingPatchClauses + | alterSystemSecuriyClauses + | affinityClauses + | shutdownDispatcherClause + | registerClause + | setClause + | resetClause + | relocateClientClause + | cancelSqlClause + | flushPasswordfileMetadataCacheClause + ; + +archiveLogClause + : ARCHIVE LOG instanceClause? (sequenceClause | changeClause | currentClause | groupClause | logfileClause | nextClause | allClause) toLocationClause? + ; + +checkpointClause + : CHECKPOINT (GLOBAL | LOCAL)? + ; + +checkDatafilesClause + : CHECK DATAFILES (GLOBAL | LOCAL)? + ; + +distributedRecovClauses + : (ENABLE | DISABLE) DISTRIBUTED RECOVERY + ; + +flushClause + : FLUSH flushClauseOption + ; + +endSessionClauses + : (disconnectSessionClause | killSessionClause) (IMMEDIATE | NOREPLY)? + ; + +switchLogfileClause + : SWITCH LOGFILE + ; + +suspendResumeClause + : SUSPEND | RESUME + ; + +quiesceClauses + : QUIESCE RESTRICTED | UNQUIESCE + ; + +rollingMigrationClauses + : startRollingMigrationClause | stopRollingMigrationClause + ; + +rollingPatchClauses + : startRollingPatchClause | stopRollingPatchClause + ; + +alterSystemSecuriyClauses + : restrictedSessionClause | setEncryptionWalletOpenClause | setEncryptionWalletCloseClause | setEncryptionKeyClause + ; + +affinityClauses + : enableAffinityClause | disableAffinityClause + ; + +shutdownDispatcherClause + : SHUTDOWN IMMEDIATE? dispatcherName + ; + +registerClause + : REGISTER + ; + +setClause + : SET alterSystemSetClause+ + ; + +resetClause + : RESET alterSystemResetClause+ + ; + +relocateClientClause + : RELOCATE CLIENT clientId + ; + +cancelSqlClause + : CANCEL SQL SQ_ sessionId serialNumber instanceId? sqlId? SQ_ + ; + +flushPasswordfileMetadataCacheClause + : FLUSH PASSWORDFILE_METADATA_CACHE + ; + +instanceClause + : INSTANCE instanceName + ; + +sequenceClause + : SEQUENCE numberLiterals + ; + +changeClause + : CHANGE numberLiterals + ; + +currentClause + : CURRENT NOSWITCH? + ; + +groupClause + : GROUP numberLiterals + ; + +logfileClause + : LOGFILE logFileName (USING BACKUP CONTROLFILE)? + ; + +nextClause + : NEXT + ; + +allClause + : ALL + ; + +toLocationClause + : TO logFileGroupsArchivedLocationName + ; + +flushClauseOption + : sharedPoolClause | globalContextClause | bufferCacheClause | flashCacheClause | redoToClause + ; + +disconnectSessionClause + : DISCONNECT SESSION SQ_ numberLiterals COMMA_ numberLiterals SQ_ POST_TRANSACTION? + ; + +killSessionClause + : KILL SESSION SQ_ numberLiterals COMMA_ numberLiterals (COMMA_ AT_ numberLiterals)? SQ_ + ; + +startRollingMigrationClause + : START ROLLING MIGRATION TO asmVersion + ; + +stopRollingMigrationClause + : STOP ROLLING MIGRATION + ; + +startRollingPatchClause + : START ROLLING PATCH + ; + +stopRollingPatchClause + : STOP ROLLING PATCH + ; + +restrictedSessionClause + : (ENABLE | DISABLE) RESTRICTED SESSION + ; + +setEncryptionWalletOpenClause + : SET ENCRYPTION WALLET OPEN IDENTIFIED BY (walletPassword | hsmAuthString) Review comment: ![walletOpenClause](https://user-images.githubusercontent.com/48581379/117255886-d1397400-ae67-11eb-9ef0-698899457128.png) Since I specified `walletPassword` and `hsmAuthString` as `stringLiterals`, I thought when we type either one of these would still be wrapped by double quotes. So I didn't double quotes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org