[GitHub] [shardingsphere-elasticjob] TeslaCN commented on a change in pull request #1890: Use a auto increment unique identity to Mysql InnoDB PRIMARY KEY

[GitBox]

TeslaCN commented on a change in pull request #1890:
URL: 
https://github.com/apache/shardingsphere-elasticjob/pull/1890#discussion_r634453766



##########
File path: pom.xml
##########
@@ -53,7 +53,7 @@
         <curator.version>5.1.0</curator.version>
         <lombok.version>1.18.12</lombok.version>
         <aspectj.version>1.9.1</aspectj.version>
-        <slf4j.version>1.7.7</slf4j.version>
+        <slf4j.version>1.7.25</slf4j.version>

Review comment:
       Could you please keep the original version?

##########
File path: 
elasticjob-ecosystem/elasticjob-tracing/elasticjob-tracing-rdb/pom.xml
##########
@@ -79,5 +79,21 @@
             <groupId>com.h2database</groupId>
             <artifactId>h2</artifactId>
         </dependency>
+        <dependency>
+            <groupId>org.slf4j</groupId>
+            <artifactId>slf4j-api</artifactId>

Review comment:
       Is it necessary to declare this dependency here?

##########
File path: 
elasticjob-ecosystem/elasticjob-tracing/elasticjob-tracing-rdb/src/main/java/org/apache/shardingsphere/elasticjob/tracing/rdb/storage/RDBJobEventStorage.java
##########
@@ -358,9 +358,19 @@ private String truncateString(final String str) {
             preparedStatement.setString(1, taskId);
             try (ResultSet resultSet = preparedStatement.executeQuery()) {
                 while (resultSet.next()) {
-                    JobStatusTraceEvent jobStatusTraceEvent = new 
JobStatusTraceEvent(resultSet.getString(1), resultSet.getString(2), 
resultSet.getString(3), resultSet.getString(4),
-                            resultSet.getString(5), 
Source.valueOf(resultSet.getString(6)), resultSet.getString(7), 
resultSet.getString(8),
-                            State.valueOf(resultSet.getString(9)), 
resultSet.getString(10), new SimpleDateFormat("yyyy-MM-dd 
HH:mm:ss").parse(resultSet.getString(11)));
+                    JobStatusTraceEvent jobStatusTraceEvent = new 
JobStatusTraceEvent(

Review comment:
       Could you please keep the original formats?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org