[GitHub] [shardingsphere] ThanoshanMV commented on pull request #10381: Proofread Oracle `SELECT` subquery clause

Tue, 18 May 2021 11:02:13 -0700 


ThanoshanMV commented on pull request #10381:
URL: https://github.com/apache/shardingsphere/pull/10381#issuecomment-843407879


   I visited `forUpdateClause` similar to `MySQLStatementSQLVisitor` as it 
contained tables and columns and I tried to assert columns in the 
`LockClauseAssert`. 
   
   I didn't remove the existing `subquery` rule but modified it as `LP_ 
selectSubquery RP_`. After changing  `subquery` rule, although the build 
succeeded, the output looked like this:
   
![TestOutput](https://user-images.githubusercontent.com/48581379/118700230-0fec0880-b830-11eb-83cc-8fc5170e1853.png)
   
   But I tried to visit Intellij's ANTLR preview for one of these SQL, it 
parsed them well:
   
![NoViableAlternativeInput](https://user-images.githubusercontent.com/48581379/118701121-ff885d80-b830-11eb-84d1-6c14b3e8baff.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to