tristaZero commented on a change in pull request #10651:
URL: https://github.com/apache/shardingsphere/pull/10651#discussion_r649712024
##########
File path:
shardingsphere-infra/shardingsphere-infra-common/src/main/java/org/apache/shardingsphere/infra/metadata/schema/builder/loader/ColumnMetaDataLoader.java
##########
@@ -76,15 +75,13 @@
}
}
}
- try (Statement statement = connection.createStatement(); ResultSet
resultSet = statement.executeQuery(generateEmptyResultSQL(tableNamePattern,
databaseType))) {
- for (String each : columnNames) {
-
isCaseSensitives.add(resultSet.getMetaData().isCaseSensitive(resultSet.findColumn(each)));
+ try (ResultSet resultSet =
connection.createStatement().executeQuery(generateEmptyResultSQL(tableNamePattern,
databaseType))) {
Review comment:
Do you think the statement from `createStatement()` still needs to be
closed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
