wgy8283335 commented on a change in pull request #10768:
URL: https://github.com/apache/shardingsphere/pull/10768#discussion_r650334988
##########
File path:
shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/core/visitor/SQLVisitorRule.java
##########
@@ -108,6 +108,8 @@
DROP_VIEW("DropView", SQLStatementType.DDL),
+ ANALYZE("Analyze", SQLStatementType.DDL),
Review comment:
Why set `Analyze` as DDL?
##########
File path:
shardingsphere-sql-parser/shardingsphere-sql-parser-test/src/main/java/org/apache/shardingsphere/test/sql/parser/parameterized/asserts/statement/ddl/DDLStatementAssert.java
##########
@@ -87,6 +90,8 @@ public static void assertIs(final SQLCaseAssertContext
assertContext, final DDLS
AlterSessionStatementAssert.assertIs(assertContext,
(OracleAlterSessionStatement) actual, (AlterSessionStatementTestCase) expected);
} else if (actual instanceof AlterSystemStatement) {
AlterSystemStatementAssert.assertIs(assertContext,
(AlterSystemStatement) actual, (AlterSystemStatementTestCase) expected);
+ } else if (actual instanceof OracleAnalyzeStatement) {
Review comment:
Are you sure that `analyze` should be put in the DDL？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
