[GitHub] [shardingsphere] ThanoshanMV commented on pull request #10759: Add selectList, fromClause definitions for Oracle Select

Mon, 14 Jun 2021 14:31:49 -0700 


ThanoshanMV commented on pull request #10759:
URL: https://github.com/apache/shardingsphere/pull/10759#issuecomment-861010223


   `inlineExternalTable` has `columnDefinition` and 
`inlineExternalTableProperties` has `externalTableDataProps` in the 
DMLStatement. Both `columnDefinition` and `externalTableDataProps` are in 
DDLStatement.
   
   Initially I was able to put `externalTableDataProps` in BaseRule but 
couldn't able to put `columnDefinition` as its `inlineConstraint` has 
`createIndex` rule:
   
   
![createIndexClause](https://user-images.githubusercontent.com/48581379/121957485-15316a00-cd80-11eb-9ef1-e75f56b4147a.png)
   
   I also agree on not to put DDLStatement in import. I've added  
`externalTableDataProps` in BaseRule. How can we specify `columnDefinition` in 
DMLStatement?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to