[GitHub] [shardingsphere] strongduanmu commented on a change in pull request #10804: Fix insert or query by precise value error when there is no db ShardingStrategy and using unique table names

[GitBox]

strongduanmu commented on a change in pull request #10804:
URL: https://github.com/apache/shardingsphere/pull/10804#discussion_r651406199



##########
File path: 
shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-core/src/main/java/org/apache/shardingsphere/sharding/algorithm/sharding/datetime/AutoIntervalShardingAlgorithm.java
##########
@@ -84,8 +84,9 @@ private long getShardingSeconds() {
     
     @Override
     public String doSharding(final Collection<String> availableTargetNames, 
final PreciseShardingValue<Comparable<?>> shardingValue) {
+        String shardingValSuffix = 
String.valueOf(doSharding(parseDate(shardingValue.getValue())));

Review comment:
       @jianliu tableNameSuffix may be better.

##########
File path: 
shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-core/src/main/java/org/apache/shardingsphere/sharding/algorithm/sharding/datetime/IntervalShardingAlgorithm.java
##########
@@ -121,9 +120,10 @@ private ChronoUnit getStepUnit(final String stepUnit) {
     
     @Override
     public String doSharding(final Collection<String> availableTargetNames, 
final PreciseShardingValue<Comparable<?>> shardingValue) {
+        String shardingValSuffix = 
parseDateTime(shardingValue.getValue().toString()).format(tableSuffixPattern);

Review comment:
       @jianliu tableNameSuffix may be better.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org