tristaZero edited a comment on pull request #10889: URL: https://github.com/apache/shardingsphere/pull/10889#issuecomment-864955327
Hi @guimingyue , That's exactly for our first step. The content is fine with me, but I assume we need an `engine` or `mechanism` to do converting work. Instead of `all in one`, I prefer splitting `sqlNodeConverter` into many child ones, each of which just focuses its function and avoids interfering with others. I just raised a #10895 to help us do such things. How do you think? It is possible to fill #10895 with what you did in this PR? If you like, we still have other contributors who are willing to give a hand. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
