viqbgrg commented on issue #10927:
URL: 
https://github.com/apache/shardingsphere/issues/10927#issuecomment-868432076


   
https://github.com/apache/shardingsphere/blob/61e4623584899b116ea7367f40db50e5a6b34264/shardingsphere-jdbc/shardingsphere-jdbc-core/src/main/java/org/apache/shardingsphere/driver/executor/DriverJDBCExecutor.java#L42
   
   ```java
   try {
               ExecuteProcessEngine.initialize(sqlStatementContext, 
executionGroupContext, metaDataContexts.getProps());
               List<Boolean> results = 
jdbcLockEngine.execute(executionGroupContext, sqlStatementContext, routeUnits, 
callback);
               boolean result = null != results && !results.isEmpty() && null 
!= results.get(0) && results.get(0);
               
ExecuteProcessEngine.finish(executionGroupContext.getExecutionID());
               return result;
           } catch (SQLException e) {
               throw e;
           } finally {
               ExecuteProcessEngine.clean();
           }
   ```
   If it doesn't throw an exception, you won't know if the SQL executed 
successfully, so you should throw an exception


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to