xueshiji commented on a change in pull request #10956:
URL: https://github.com/apache/shardingsphere/pull/10956#discussion_r659736298
##########
File path:
shardingsphere-infra/shardingsphere-infra-common/src/main/java/org/apache/shardingsphere/infra/metadata/schema/builder/loader/dialect/OracleTableMetaDataLoader.java
##########
@@ -105,7 +107,8 @@ private ColumnMetaData loadColumnMetaData(final Map<String,
Integer> dataTypeMap
}
private String getTableMetaDataSQL(final Collection<String> existedTables,
final DatabaseMetaData metaData) throws SQLException {
- String collation = metaData.getDatabaseMajorVersion() >=
COLLATION_START_MAJOR_VERSION && metaData.getDatabaseMinorVersion() >=
COLLATION_START_MINOR_VERSION ? ", COLLATION" : "";
+ String collation = metaData.getDatabaseMajorVersion() >=
COLLATION_START_MAJOR_VERSION ? metaData.getDatabaseMinorVersion() >=
COLLATION_START_MINOR_VERSION ? ", IDENTITY_COLUMN, COLLATION"
Review comment:
@strongduanmu What do you think of it now？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
