guimingyue commented on pull request #10889: URL: https://github.com/apache/shardingsphere/pull/10889#issuecomment-871163721
> @guimingyue > > ### UT > That will be fine. Do you think `SelectStatementSqlNodeConverterTest` still needs more assertion? > > ### ShardingSphereOptimizer > Just to get the best physical plan. Please look from `optimize()` of `ShardingSphereOptimizer` which contains parsing, sqlNode converting and optimizing. Is the SQL parameter of the `optimize` method the result of the federated router? if so, what is the boundary of the federated router? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
