menghaoranss commented on a change in pull request #11101:
URL: https://github.com/apache/shardingsphere/pull/11101#discussion_r663321872
##########
File path:
shardingsphere-distsql-parser/shardingsphere-distsql-parser-engine/src/main/antlr4/imports/RDLStatement.g4
##########
@@ -58,3 +58,11 @@ user
password
: IDENTIFIER | INT | STRING
;
+
+connectionProperties
+ : connectionProperty (COMMA connectionProperty)*
+ ;
+
+connectionProperty
+ : key=IDENTIFIER EQ value=IDENTIFIER
Review comment:
Other `g4` file define properties as follows:
```
key=(IDENTIFIER | STRING) EQ value=(NUMBER | INT | STRING)
```
please confirm whether need to consider consistency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
